Avoid potential address re-use for internal fake backbuffer memory#3773
Merged
baldurk merged 1 commit intobaldurk:v1.xfrom Jan 22, 2026
Merged
Avoid potential address re-use for internal fake backbuffer memory#3773baldurk merged 1 commit intobaldurk:v1.xfrom
baldurk merged 1 commit intobaldurk:v1.xfrom
Conversation
MartynJacques-Arm
force-pushed
the
fake-backbuffer-fix
branch
from
249d33c to
ce306dc
Compare
baldurk
requested changes
Jan 20, 2026
MartynJacques-Arm
force-pushed
the
fake-backbuffer-fix
branch
from
ce306dc to
fc6f696
Compare
baldurk
requested changes
Jan 22, 2026
Owner
baldurk
left a comment
baldurk
left a comment
There was a problem hiding this comment.
Thanks for those changes - I've left a couple of minor nits but otherwise this looks good to me. It is annoying that we can't use the existing path but I think it's better to keep internal allocations and objects separate in this case.
Track fake backbuffer memory as a device address resource to defer freeing it until the end of the capture
MartynJacques-Arm
force-pushed
the
fake-backbuffer-fix
branch
from
fc6f696 to
0fc1271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track fake backbuffer memory as a device address resource to defer freeing it until the end of the capture