Fix for textures initialized with VkCopyMemoryToImage#3777
Closed
sasamiyatu wants to merge 1 commit intobaldurk:v1.xfrom
Closed
Fix for textures initialized with VkCopyMemoryToImage#3777sasamiyatu wants to merge 1 commit intobaldurk:v1.xfrom
sasamiyatu wants to merge 1 commit intobaldurk:v1.xfrom
Conversation
Owner
|
This change is not correct as it stands, serialising From what I can see possibly a needed change here is to ensure image layout tracking is updated when idle capturing, but without understanding the root problem I can't say. Can you please open a bug report following the template and provide a reproducible test case? |
Author
|
Thank you for your feedback. I did verify that these changes fixed the issue with the test case I had. I will open a bug report with a reproducible test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, textures initialized using Vulkan 1.4 vkTransitionImageLayout and vkCopyMemoryToImage functions show up as black with 'Unknown previous layout' in RenderDoc captures. With these changes, these textures show up correctly with the correct layout in captures.