Clear results when start refreshing.

Author: hostep

Storage/AbstractStorage.php

@@ -13,4 +13,9 @@ public function update(string $identifier, array $data): bool
 
         return $this->write($identifier, $newData);
     }
+
+    public function clear(string $identifier): bool
+    {
+        return $this->write($identifier, []);
+    }
 }

Storage/StorageInterface.php

@@ -20,4 +20,6 @@ public function read(string $identifier): array;
      * @param array<string, mixed> $data
      */
     public function update(string $identifier, array $data): bool;
+
+    public function clear(string $identifier): bool;
 }

Test/Storage/CacheStorageTest.php

@@ -85,6 +85,41 @@ public function testUpdatingExisting()
         $this->assertEquals($expectedData, $cacheStorage->read($identifier));
     }
 
+    public function testClear()
+    {
+        $identifier = 'identifier';
+        $existingData = [
+            'key1' => 'value1',
+            'key2' => 'value2',
+        ];
+
+        $expectedData = [];
+
+        /** @var AppCache&MockObject */
+        $cacheMock = $this
+            ->getMockBuilder(AppCache::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $cacheMock->expects($this->exactly(2))
+            ->method('save')
+            ->withConsecutive(
+                [$this->jsonEncode($existingData)],
+                [$this->jsonEncode($expectedData)]
+            )
+            ->willReturn(true);
+
+        $cacheMock->expects($this->exactly(1))
+            ->method('load')
+            ->willReturn($this->jsonEncode($expectedData));
+
+        $cacheStorage = new CacheStorage($cacheMock);
+        $cacheStorage->write($identifier, $existingData);
+        $cacheStorage->clear($identifier);
+
+        $this->assertEquals($expectedData, $cacheStorage->read($identifier));
+    }
+
     /**
      * @param array<string, string> $data
      */

Updater/Catalog/Category/UrlKey.php

@@ -39,6 +39,8 @@ public function refresh(string $initiator): array
             throw new AlreadyRefreshingException($errorMsg);
         }
 
+        $this->storage->clear($storageIdentifier);
+
         $this->metaStorage->setErrorMessage($storageIdentifier, '');
         $this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);
 

Updater/Catalog/Category/UrlPath.php

@@ -39,6 +39,8 @@ public function refresh(string $initiator): array
             throw new AlreadyRefreshingException($errorMsg);
         }
 
+        $this->storage->clear($storageIdentifier);
+
         $this->metaStorage->setErrorMessage($storageIdentifier, '');
         $this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);
 

Updater/Catalog/Product/UrlKey.php

@@ -39,6 +39,8 @@ public function refresh(string $initiator): array
             throw new AlreadyRefreshingException($errorMsg);
         }
 
+        $this->storage->clear($storageIdentifier);
+
         $this->metaStorage->setErrorMessage($storageIdentifier, '');
         $this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);
 

Updater/Catalog/Product/UrlPath.php

@@ -39,6 +39,8 @@ public function refresh(string $initiator): array
             throw new AlreadyRefreshingException($errorMsg);
         }
 
+        $this->storage->clear($storageIdentifier);
+
         $this->metaStorage->setErrorMessage($storageIdentifier, '');
         $this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);