Updated phpstan from 0.12.28 to 0.12.31 and fixed the new errors it reported.

hostep · hostep · commit b26e352db08e · 2020-06-26T22:51:37.000+02:00
diff --git a/Model/ResourceModel/Catalog/Category/UrlKeyCollection.php b/Model/ResourceModel/Catalog/Category/UrlKeyCollection.php
@@ -91,6 +91,9 @@ public function createDataObject(array $arguments = []): DataObject
         return $obj;
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setItems(array $items = null)
     {
         throw new LocalizedException(__('Not implemented: setItems!'));
@@ -101,6 +104,9 @@ public function getAggregations()
         throw new LocalizedException(__('Not implemented: getAggregations!'));
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setAggregations($aggregations)
     {
         throw new LocalizedException(__('Not implemented: setAggregations!'));
@@ -111,6 +117,9 @@ public function getSearchCriteria()
         throw new LocalizedException(__('Not implemented: getSearchCriteria!'));
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setSearchCriteria(SearchCriteriaInterface $searchCriteria)
     {
         throw new LocalizedException(__('Not implemented: setSearchCriteria!'));
@@ -121,6 +130,9 @@ public function getTotalCount()
         return $this->getSize();
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
diff --git a/Model/ResourceModel/Catalog/Category/UrlPathCollection.php b/Model/ResourceModel/Catalog/Category/UrlPathCollection.php
@@ -91,6 +91,9 @@ public function createDataObject(array $arguments = []): DataObject
         return $obj;
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setItems(array $items = null)
     {
         throw new LocalizedException(__('Not implemented: setItems!'));
@@ -101,6 +104,9 @@ public function getAggregations()
         throw new LocalizedException(__('Not implemented: getAggregations!'));
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setAggregations($aggregations)
     {
         throw new LocalizedException(__('Not implemented: setAggregations!'));
@@ -111,6 +117,9 @@ public function getSearchCriteria()
         throw new LocalizedException(__('Not implemented: getSearchCriteria!'));
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setSearchCriteria(SearchCriteriaInterface $searchCriteria)
     {
         throw new LocalizedException(__('Not implemented: setSearchCriteria!'));
@@ -121,6 +130,9 @@ public function getTotalCount()
         return $this->getSize();
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
diff --git a/Model/ResourceModel/Catalog/Product/UrlKeyCollection.php b/Model/ResourceModel/Catalog/Product/UrlKeyCollection.php
@@ -91,6 +91,9 @@ public function createDataObject(array $arguments = []): DataObject
         return $obj;
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setItems(array $items = null)
     {
         throw new LocalizedException(__('Not implemented: setItems!'));
@@ -101,6 +104,9 @@ public function getAggregations()
         throw new LocalizedException(__('Not implemented: getAggregations!'));
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setAggregations($aggregations)
     {
         throw new LocalizedException(__('Not implemented: setAggregations!'));
@@ -111,6 +117,9 @@ public function getSearchCriteria()
         throw new LocalizedException(__('Not implemented: getSearchCriteria!'));
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setSearchCriteria(SearchCriteriaInterface $searchCriteria)
     {
         throw new LocalizedException(__('Not implemented: setSearchCriteria!'));
@@ -121,6 +130,9 @@ public function getTotalCount()
         return $this->getSize();
     }
 
+    /**
+     * @return UrlKeyCollection<DataObject>
+     */
     public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
diff --git a/Model/ResourceModel/Catalog/Product/UrlPathCollection.php b/Model/ResourceModel/Catalog/Product/UrlPathCollection.php
@@ -91,6 +91,9 @@ public function createDataObject(array $arguments = []): DataObject
         return $obj;
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setItems(array $items = null)
     {
         throw new LocalizedException(__('Not implemented: setItems!'));
@@ -101,6 +104,9 @@ public function getAggregations()
         throw new LocalizedException(__('Not implemented: getAggregations!'));
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setAggregations($aggregations)
     {
         throw new LocalizedException(__('Not implemented: setAggregations!'));
@@ -111,6 +117,9 @@ public function getSearchCriteria()
         throw new LocalizedException(__('Not implemented: getSearchCriteria!'));
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setSearchCriteria(SearchCriteriaInterface $searchCriteria)
     {
         throw new LocalizedException(__('Not implemented: setSearchCriteria!'));
@@ -121,6 +130,9 @@ public function getTotalCount()
         return $this->getSize();
     }
 
+    /**
+     * @return UrlPathCollection<DataObject>
+     */
     public function setTotalCount($totalCount)
     {
         throw new LocalizedException(__('Not implemented: setTotalCount!'));
diff --git a/composer.lock b/composer.lock

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,9 @@ public function createDataObject(array $arguments = []): DataObject`
`91`	`91`	`return $obj;`
`92`	`92`	`}`
`93`	`93`
	`94`	`+ /**`
	`95`	`+ * @return UrlKeyCollection<DataObject>`
	`96`	`+ */`
`94`	`97`	`public function setItems(array $items = null)`
`95`	`98`	`{`
`96`	`99`	`throw new LocalizedException(__('Not implemented: setItems!'));`
`@@ -101,6 +104,9 @@ public function getAggregations()`
`101`	`104`	`throw new LocalizedException(__('Not implemented: getAggregations!'));`
`102`	`105`	`}`
`103`	`106`
	`107`	`+ /**`
	`108`	`+ * @return UrlKeyCollection<DataObject>`
	`109`	`+ */`
`104`	`110`	`public function setAggregations($aggregations)`
`105`	`111`	`{`
`106`	`112`	`throw new LocalizedException(__('Not implemented: setAggregations!'));`
`@@ -111,6 +117,9 @@ public function getSearchCriteria()`
`111`	`117`	`throw new LocalizedException(__('Not implemented: getSearchCriteria!'));`
`112`	`118`	`}`
`113`	`119`
	`120`	`+ /**`
	`121`	`+ * @return UrlKeyCollection<DataObject>`
	`122`	`+ */`
`114`	`123`	`public function setSearchCriteria(SearchCriteriaInterface $searchCriteria)`
`115`	`124`	`{`
`116`	`125`	`throw new LocalizedException(__('Not implemented: setSearchCriteria!'));`
`@@ -121,6 +130,9 @@ public function getTotalCount()`
`121`	`130`	`return $this->getSize();`
`122`	`131`	`}`
`123`	`132`
	`133`	`+ /**`
	`134`	`+ * @return UrlKeyCollection<DataObject>`
	`135`	`+ */`
`124`	`136`	`public function setTotalCount($totalCount)`
`125`	`137`	`{`
`126`	`138`	`throw new LocalizedException(__('Not implemented: setTotalCount!'));`