This repository was archived by the owner on Feb 16, 2021. It is now read-only.
Allow setting the local timezone#54
Open
pschmitt wants to merge 1 commit intobalena-io-experimental:masterfrom
Open
Allow setting the local timezone#54pschmitt wants to merge 1 commit intobalena-io-experimental:masterfrom
pschmitt wants to merge 1 commit intobalena-io-experimental:masterfrom
Conversation
imrehg
previously approved these changes
Apr 10, 2019
Contributor
imrehg
left a comment
imrehg
left a comment
There was a problem hiding this comment.
LGTM, thanks @pschmitt and sorry for getting back to you this late!
Do you think it would be possible to update the code a bit?
- rebase on the current master
- add the required footers to the commit message:
Change-type: minor
Signed-off-by: .....(youremail)...
That would allow us to merge this change properly.
kaisoz
added
the
versionbot/pr-draft
ghost
dismissed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new environment variable
TIMEZONEso that users can set the local timezone in the container. By defaultUTCis used which may not be ideal for everyone, especially when displaying time.