Use balena-compose-parser for compose file parsing #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cywang117
force-pushed
the
parse-compose-with-compose-parser
branch
2 times, most recently
from
52b3d11 to
4b246cc
Compare
cywang117
force-pushed
the
parse-compose-with-compose-parser
branch
2 times, most recently
from
3e3cbce to
a0523fc
Compare
Contributor
Author
|
/rebase |
Signed-off-by: Christina Ying Wang <[email protected]>
Signed-off-by: Christina Ying Wang <[email protected]>
Change-type: major Signed-off-by: Christina Ying Wang <[email protected]>
Signed-off-by: Christina Ying Wang <[email protected]>
defaultComposition originally outputted a YAML string as parse.normalize is able to receive YAML strings, but balena-compose-parser only receives filepaths. Therefore, outputting a Composition object will reduce complexity. Change-type: patch Signed-off-by: Christina Ying Wang <[email protected]>
git-basejump
bot
force-pushed
the
parse-compose-with-compose-parser
branch
from
fc4a07c to
8f175d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using balena-compose-parser for compose parsing functionality. Compose-parser is now the owner of composition types, parsing, and image descriptor generation, so these functionalities have been removed from balena-compose. Balena-compose remains the source of truth for the default composition (
defaultComposition()).As such, any consumers that previously imported balena-compose for its composition parsing functionality, should now import balena-compose-parser directly.
Change-type: major