Skip to content

🐛 fix(Balheading): BalHeading level prop does not change visual style #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

🐛 fix(Balheading): BalHeading level prop does not change visual style #1851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c54838b
Create PR for #1844
github-actions[bot] Nov 7, 2025
7aa03a3
fix(heading): get font size before render
hirsch88 Nov 7, 2025
81ccfd5
chore: add debug logs
hirsch88 Nov 7, 2025
986bec7
fix(core): enable experimentalScopedSlotChanges and experimentalSlotF…
hirsch88 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-rules-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**heading**: get font size before render
10 changes: 10 additions & 0 deletions packages/core/src/components/bal-heading/bal-heading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export class Heading implements ComponentInterface {

@Watch('level')
levelWatcher() {
console.log('level')
this.updateAutoFontSize()
}

Expand All @@ -47,6 +48,7 @@ export class Heading implements ComponentInterface {

@Watch('visualLevel')
visualLevelWatcher() {
console.log('visualLevelWatcher')
this.updateAutoFontSize()
}

Expand Down Expand Up @@ -98,6 +100,12 @@ export class Heading implements ComponentInterface {
*/

connectedCallback(): void {
console.log('connectedCallback')
this.updateAutoFontSize()
}

componentWillRender(): Promise<void> | void {
console.log('componentWillRender')
this.updateAutoFontSize()
}

Expand Down Expand Up @@ -160,6 +168,8 @@ export class Heading implements ComponentInterface {
const Heading = this.tag
const fontColor = this.fontColor

console.log('render')

return (
<Host
class={{
Expand Down
2 changes: 2 additions & 0 deletions packages/core/stencil.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ export const config: Config = {
],
extras: {
initializeNextTick: true,
experimentalScopedSlotChanges: true,
experimentalSlotFixes: true,
},
outputTargets: [
{
Expand Down
Loading