Skip to content

Ignore user null check#25

Open
panbohaha wants to merge 1 commit intobamcis-io:mainfrom
panbohaha:patch-1
Open

Ignore user null check#25
panbohaha wants to merge 1 commit intobamcis-io:mainfrom
panbohaha:patch-1

Conversation

@panbohaha
Copy link

when deploy to docker, we can't get the Username or User from evn.

when deploy to docker, we can't get the Username or User from evn.
@hakenmt
Copy link
Contributor

hakenmt commented Oct 23, 2024

Could probably just set USER or USERNAME in the docker environment? There are other places that check for the username to not be null or empty, particularly here

private bool CheckConfiguration(out Exception ex)
, which is called before executing query. So allowing a username to be null or empty has some cascading effects. Is there a better default value for this when run in a docker environment?

@panbohaha
Copy link
Author

yes, for now, we add the UserName into docker env. I think the CheckConfiguration function is okay. for my issue is when init the class PrestoClientSessionConfig we got the error.
the code is like this:

var config = new PrestoClientSessionConfig(){
UserName = "test"
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants