Introduced internal analysis plots#79
Open
SGHoekstra wants to merge 6 commits intobancaditalia:mainfrom
Open
Conversation
Created functions to analyse cross and autocorrrelations. Note, we need sufficiently long simulations for the estimates of the cross and autocorrelations to be stable.
…e_multiple.jl to its original state.
ameligrana
reviewed
Jul 15, 2025
Collaborator
|
Yes @SGHoekstra, I totally agree with @Tortar here. The bulk of your work should be inside the package so that other people can use it too. It suffices to move the main functions to some module within the utils folder and call them from the example |
Major refactor of cross-correlation analysis in examples/analysis/figs/crosscorrelations.jl, including improved simulation and analysis workflow, modernized plotting, and use of new correlation utilities. Added src/utils/correlation_utils.jl with HP filter, cross-correlation, autocorrelation, and formatting functions.
Collaborator
|
Is this ready for review @SGHoekstra? |
Collaborator
Author
|
Yes it is! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created functions to analyse cross and autocorrrelations. Note, we need sufficiently long simulations for the estimates of the cross and autocorrelations to be stable.