Added fetching data to setup initialOptions. Refactored server. refs #94 #121
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ | |
|
|
||
| # misc | ||
| .DS_Store | ||
| .env | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import axios from 'axios'; | ||
| import { useQuery } from 'react-query'; | ||
|
|
||
| import { Option } from '../types'; | ||
|
|
||
| // fetches options and return only choices | ||
| const getOptions = async () => { | ||
| const { data } = await axios({ | ||
| method: 'get', | ||
| url: `${process.env.REACT_APP_BACKEND_URL}/choice`, | ||
| responseType: 'json', | ||
| withCredentials: true, | ||
| }); | ||
| return data.choices; | ||
| }; | ||
|
|
||
| // query for options | ||
| export default function useOptions() { | ||
| return useQuery<Option[], Error>('options', getOptions, { | ||
| refetchOnWindowFocus: false, | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| type Attribute = { | ||
| size: string; | ||
| color: string; | ||
| }; | ||
|
|
||
| // type for option | ||
| export type Option = { | ||
| id: string; | ||
| title: string; | ||
| subtitle: string; | ||
| content: string; | ||
| attributes: Attribute[]; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,17 @@ | ||
| const cors = require('cors'); | ||
| const express = require('express'); | ||
| const mockApi = require('./API/mockApi'); | ||
|
|
||
| var app = express(); | ||
| app.use( | ||
| cors({ | ||
|
|
||
| origin: 'http://localhost:3000', | ||
| credentials: true, | ||
| }) | ||
| ); | ||
| app.use(express.json()); | ||
| const serverPort = 4000; | ||
| app.listen(serverPort, () => | ||
| console.log(`server started successfully at port ${serverPort}....`) | ||
| ); | ||
| app.use('/', mockApi); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,6 @@ | |
| "author": "eagle", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "cors": "^2.8.5", | ||
| "express": "^4.17.1" | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the more "native"
fetchinstead of axios to make the requests? Any thoughts?I'm asking it because every package we add to the project increases the bundle size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm just used to axios, but sure, I can rewrite this with fetch. Keeping bundle size as small as possible makes sense