Skip to content

Make sure we don't forget post-loop actions. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bangerth merged 1 commit into from
Nov 18, 2024
Merged

Make sure we don't forget post-loop actions. #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions include/sampleflow/producers/differential_evaluation_mh.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ namespace SampleFlow
// "generations" and an inner loop over the individual chains. We
// exit from the inner loop when we have reached the desired number of
// samples.
for (types::sample_index generation=0; true; ++generation)
for (types::sample_index generation=0; generation * n_chains < n_samples; ++generation)
{
// A vector that will contain the std::future objects used to
// hold results of either synchronous or asynchronous
Expand Down Expand Up @@ -315,11 +315,10 @@ namespace SampleFlow
// guarantees a stable order.
for (typename std::vector<OutputType>::size_type chain = 0; chain < n_chains; ++chain)
{
// Return if we have already generated the desired number of
// samples. The ScopeExit object above also makes sure that
// we flush the downstream consumers.
// Break the loop if we have already generated the desired number of
// samples:
if (generation * n_chains + chain >= n_samples)
return;
break;

// Wait for the futures to be ready. Then output the new sample
// (which may of course be equal to the old sample).
Expand Down
Loading