Skip to content

Comments

fix: person portrait history#1470

Open
inchei wants to merge 2 commits intobangumi:masterfrom
inchei:person-rev-fix
Open

fix: person portrait history#1470
inchei wants to merge 2 commits intobangumi:masterfrom
inchei:person-rev-fix

Conversation

@inchei
Copy link
Contributor

@inchei inchei commented Feb 1, 2026

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.36%. Comparing base (789a8ef) to head (36dc9f4).

Files with missing lines Patch % Lines
routes/private/routes/wiki/person/index.ts 20.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   56.39%   56.36%   -0.03%     
==========================================
  Files         136      136              
  Lines        6185     6188       +3     
  Branches     1272     1275       +3     
==========================================
  Hits         3488     3488              
  Misses       2088     2088              
- Partials      609      612       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trim21
Copy link
Contributor

trim21 commented Feb 4, 2026

感觉人物和角色的是不是应该分成两个路径

@inchei
Copy link
Contributor Author

inchei commented Feb 5, 2026

感觉人物和角色的是不是应该分成两个路径

角色路径的在这里,这里人物要用 CharacterRev 是因为特定情况下人物会用 CharacterRev 而不是 PersonRev 存,详见 #1469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants