Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
+ Coverage 56.23% 57.34% +1.11%
==========================================
Files 142 142
Lines 6284 6518 +234
Branches 1298 1340 +42
==========================================
+ Hits 3534 3738 +204
- Misses 2135 2148 +13
- Partials 615 632 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 266b96cde9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }), | ||
| }), | ||
| { | ||
| $id: 'CharacterCastRevisionWikiInfo', | ||
| }, |
There was a problem hiding this comment.
Use a unique schema id for person cast revisions
The PersonCastRevisionWikiInfo schema is registered with $id: 'CharacterCastRevisionWikiInfo', which collides with the character-cast schema. When both wiki route modules are registered (the normal server setup), this duplicate id means one schema overwrites the other, so either /characters/-/casts/revisions or /persons/-/casts/revisions will be validated and documented against the wrong shape. That can lead to response serialization dropping the actual character/person fields or throwing due to missing required fields, and the OpenAPI output will be inaccurate for at least one endpoint.
Useful? React with 👍 / 👎.
|
这个等我补上测试数据再说吧 |
|
这个缺的测试数据是啥,有没有SQL例子发一下( |
snapshot 里那些 type 5 的都是,是这样吗 SELECT
s.*,
sf.*
FROM chii_subjects s
LEFT JOIN chii_subject_fields sf
ON s.subject_id = sf.field_sid
WHERE s.subject_id IN (283, 292, 793, 993, 1263, 1428, 2089, 2129, 2425, 2427, 2474, 2782, 3018, 3183, 3625, 3690, 4124, 8474, 22267, 22273, 35866, 86773, 199229, 209563); |
|
导出了,你加到dev-env里面吧() |
typeID 写了一个缺省为 5,因为缺测试数据 subject