Skip to content

Comments

feat: relation revisions#1471

Open
inchei wants to merge 13 commits intobangumi:masterfrom
inchei:relation-rev
Open

feat: relation revisions#1471
inchei wants to merge 13 commits intobangumi:masterfrom
inchei:relation-rev

Conversation

@inchei
Copy link
Contributor

@inchei inchei commented Feb 1, 2026

typeID 写了一个缺省为 5,因为缺测试数据 subject

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 86.32479% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.34%. Comparing base (6a32bcf) to head (85f7f74).

Files with missing lines Patch % Lines
routes/private/routes/wiki/subject/index.ts 86.66% 6 Missing and 6 partials ⚠️
routes/private/routes/wiki/character/index.ts 86.11% 4 Missing and 6 partials ⚠️
routes/private/routes/wiki/person/index.ts 86.11% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
+ Coverage   56.23%   57.34%   +1.11%     
==========================================
  Files         142      142              
  Lines        6284     6518     +234     
  Branches     1298     1340      +42     
==========================================
+ Hits         3534     3738     +204     
- Misses       2135     2148      +13     
- Partials      615      632      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inchei inchei changed the title feat: subject relation revisions feat: relation revisions Feb 3, 2026
@everpcpc
Copy link
Contributor

everpcpc commented Feb 4, 2026

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 266b96cde9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 133 to 137
}),
}),
{
$id: 'CharacterCastRevisionWikiInfo',
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use a unique schema id for person cast revisions

The PersonCastRevisionWikiInfo schema is registered with $id: 'CharacterCastRevisionWikiInfo', which collides with the character-cast schema. When both wiki route modules are registered (the normal server setup), this duplicate id means one schema overwrites the other, so either /characters/-/casts/revisions or /persons/-/casts/revisions will be validated and documented against the wrong shape. That can lead to response serialization dropping the actual character/person fields or throwing due to missing required fields, and the OpenAPI output will be inaccurate for at least one endpoint.

Useful? React with 👍 / 👎.

@mergify mergify bot added the conflict label Feb 5, 2026
@mergify mergify bot removed the conflict label Feb 5, 2026
@trim21
Copy link
Contributor

trim21 commented Feb 5, 2026

这个等我补上测试数据再说吧

@trim21
Copy link
Contributor

trim21 commented Feb 8, 2026

这个缺的测试数据是啥,有没有SQL例子发一下(

@inchei
Copy link
Contributor Author

inchei commented Feb 21, 2026

这个缺的测试数据是啥,有没有SQL例子发一下(

snapshot 里那些 type 5 的都是,是这样吗

SELECT 
    s.*,
    sf.*
FROM chii_subjects s
LEFT JOIN chii_subject_fields sf 
    ON s.subject_id = sf.field_sid
WHERE s.subject_id IN (283, 292, 793, 993, 1263, 1428, 2089, 2129, 2425, 2427, 2474, 2782, 3018, 3183, 3625, 3690, 4124, 8474, 22267, 22273, 35866, 86773, 199229, 209563);

@trim21
Copy link
Contributor

trim21 commented Feb 21, 2026

s.sql

导出了,你加到dev-env里面吧()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants