fix: Add missing prototypes

The missing prototype error was being triggered due to one of the
following:

- the prototype was effectively missing;
- the prototype was ill defined (mainly, no paramter function prototypes
  missed 'void' as paramter list;
- the function did not have a prototype but did not require it. Mostly,
  because it was only used in the compilation unit - in this case to avoid,
  the error it must be defined as static;
  In some other cases these functions had a prototype defined which was
  not necessary and was thus removed.

Signed-off-by: Miguel Silva <[email protected]>

Author: miguelafsilva5

src/arch/armv8/aarch32/aborts.c

@@ -3,7 +3,7 @@
  * Copyright (c) Bao Project and Contributors. All rights reserved.
  */
 
-#include <bao.h>
+#include <arch/aborts.h>
 #include <arch/sysregs.h>
 #include <cpu.h>
 

src/arch/armv8/aarch64/aborts.c

@@ -3,7 +3,7 @@
  * Copyright (c) Bao Project and Contributors. All rights reserved.
  */
 
-#include <bao.h>
+#include <arch/aborts.h>
 #include <arch/sysregs.h>
 #include <cpu.h>
 

src/arch/armv8/aborts.c

@@ -14,7 +14,8 @@
 
 typedef void (*abort_handler_t)(unsigned long, unsigned long, unsigned long, unsigned long);
 
-void aborts_data_lower(unsigned long iss, unsigned long far, unsigned long il, unsigned long ec)
+static void aborts_data_lower(unsigned long iss, unsigned long far, unsigned long il,
+    unsigned long ec)
 {
     UNUSED_ARG(ec);
 
@@ -52,7 +53,7 @@ void aborts_data_lower(unsigned long iss, unsigned long far, unsigned long il, u
     }
 }
 
-long int standard_service_call(unsigned long _fn_num)
+static long int standard_service_call(unsigned long _fn_num)
 {
     UNUSED_ARG(_fn_num);
 
@@ -99,12 +100,12 @@ static inline void syscall_handler(unsigned long iss, unsigned long far, unsigne
     vcpu_writereg(cpu()->vcpu, 0, (unsigned long)ret);
 }
 
-void hvc_handler(unsigned long iss, unsigned long far, unsigned long il, unsigned long ec)
+static void hvc_handler(unsigned long iss, unsigned long far, unsigned long il, unsigned long ec)
 {
     syscall_handler(iss, far, il, ec);
 }
 
-void smc_handler(unsigned long iss, unsigned long far, unsigned long il, unsigned long ec)
+static void smc_handler(unsigned long iss, unsigned long far, unsigned long il, unsigned long ec)
 {
     UNUSED_ARG(far);
 
@@ -128,7 +129,7 @@ static regaddr_t reg_addr_translate(unsigned long iss)
     }
 }
 
-void sysreg_handler(unsigned long iss, unsigned long far, unsigned long il, unsigned long ec)
+static void sysreg_handler(unsigned long iss, unsigned long far, unsigned long il, unsigned long ec)
 {
     UNUSED_ARG(far);
 
@@ -174,7 +175,7 @@ abort_handler_t abort_handlers[64] = {
     [ESR_EC_HVC64] = hvc_handler,
 };
 
-void aborts_sync_handler()
+void aborts_sync_handler(void)
 {
     unsigned long esr = sysreg_esr_el2_read();
     unsigned long far = sysreg_far_el2_read();

src/arch/armv8/armv8-a/aarch64/vmm.c

@@ -7,7 +7,7 @@
 #include <arch/sysregs.h>
 #include <page_table.h>
 
-void vmm_arch_init_tcr()
+void vmm_arch_init_tcr(void)
 {
     /**
      * Check available physical address range which will limit IPA size. Patch 2-stage page table

src/arch/armv8/armv8-a/inc/arch/smmuv2.h

@@ -373,10 +373,10 @@ struct smmu_cntxt_hw {
 
 typedef deviceid_t streamid_t;
 
-void smmu_init();
+void smmu_init(void);
 
-ssize_t smmu_alloc_ctxbnk();
-ssize_t smmu_alloc_sme();
+ssize_t smmu_alloc_ctxbnk(void);
+ssize_t smmu_alloc_sme(void);
 void smmu_write_ctxbnk(size_t ctx_id, paddr_t root_pt, asid_t vm_id);
 void smmu_write_sme(size_t sme, streamid_t mask, streamid_t id, bool group);
 void smmu_write_s2c(size_t sme, size_t ctx_id);

src/arch/armv8/armv8-a/iommu.c

@@ -9,7 +9,7 @@
 #include <mem.h>
 #include <config.h>
 
-bool iommu_arch_init()
+bool iommu_arch_init(void)
 {
     if (cpu_is_master() && platform.arch.smmu.base) {
         smmu_init();

src/arch/armv8/armv8-a/psci.c

@@ -45,7 +45,7 @@ static void psci_restore_state()
     gicc_restore_state(&cpu()->arch.profile.psci_off_state.gicc_state);
 }
 
-void psci_wake_from_powerdown()
+static void psci_wake_from_powerdown()
 {
     if (cpu()->vcpu == NULL) {
         ERROR("cpu woke up but theres no vcpu to run");
@@ -56,12 +56,12 @@ void psci_wake_from_powerdown()
     vcpu_run(cpu()->vcpu);
 }
 
-void psci_wake_from_idle()
+static void psci_wake_from_idle()
 {
     cpu_idle_wakeup();
 }
 
-void psci_wake_from_off();
+void psci_wake_from_off(void);
 
 void (*psci_wake_handlers[PSCI_WAKEUP_NUM])(void) = {
     [PSCI_WAKEUP_CPU_OFF] = psci_wake_from_off,

src/arch/armv8/armv8-a/smmuv2.c

@@ -116,7 +116,7 @@ static void smmu_check_features()
     }
 }
 
-void smmu_init()
+void smmu_init(void)
 {
     /*
      * Alloc pages for global address space.
@@ -178,7 +178,7 @@ void smmu_init()
     smmu.hw.glbl_rs0->CR0 = cr0;
 }
 
-ssize_t smmu_alloc_ctxbnk()
+ssize_t smmu_alloc_ctxbnk(void)
 {
     spin_lock(&smmu.ctx_lock);
     /* Find a free context bank. */
@@ -243,7 +243,7 @@ void smmu_write_ctxbnk(size_t ctx_id, paddr_t root_pt, asid_t vm_id)
     spin_unlock(&smmu.ctx_lock);
 }
 
-ssize_t smmu_alloc_sme()
+ssize_t smmu_alloc_sme(void)
 {
     spin_lock(&smmu.sme_lock);
     /* Find a free sme. */

src/arch/armv8/armv8-r/mpu.c

@@ -167,7 +167,7 @@ static mpid_t mpu_entry_allocate()
     return reg_num;
 }
 
-bool mem_region_get_overlap(struct mp_region* reg1, struct mp_region* reg2,
+static bool mem_region_get_overlap(struct mp_region* reg1, struct mp_region* reg2,
     struct mp_region* overlap)
 {
     bool regions_overlap = mem_regions_overlap(reg1, reg2);
@@ -541,7 +541,7 @@ bool mpu_unmap(priv_t priv, struct mp_region* mpr)
     return size_left == 0;
 }
 
-void mpu_init()
+void mpu_init(void)
 {
     bitmap_clear_consecutive(cpu()->arch.profile.mpu.bitmap, 0, mpu_num_entries());
     list_init(&cpu()->arch.profile.mpu.order.list);

src/arch/armv8/asm_defs.c

@@ -8,8 +8,7 @@
 #include <vm.h>
 #include <platform.h>
 
-void cpu_defines() __attribute__((used));
-void cpu_defines()
+__attribute__((used)) static void cpu_defines()
 {
     DEFINE_SIZE(CPU_SIZE, struct cpu);
 
@@ -19,16 +18,14 @@ void cpu_defines()
     DEFINE_OFFSET(CPU_VCPU_OFF, struct cpu, vcpu);
 }
 
-void vcpu_defines() __attribute__((used));
-void vcpu_defines()
+__attribute__((used)) static void vcpu_defines()
 {
     DEFINE_SIZE(VCPU_ARCH_SIZE, struct vcpu_arch);
     DEFINE_OFFSET(VCPU_REGS_OFF, struct vcpu, regs);
     DEFINE_SIZE(VCPU_REGS_SIZE, struct arch_regs);
 }
 
-void platform_defines() __attribute__((used));
-void platform_defines()
+__attribute__((used)) static void platform_defines()
 {
     DEFINE_OFFSET(PLAT_CPUNUM_OFF, struct platform, cpu_num);
     DEFINE_OFFSET(PLAT_ARCH_OFF, struct platform, arch);