Add mps3 plat support #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you solve the format issue @josecm ? |
josecm
force-pushed
the
feat/add_mps3_plat_support
branch
from
1b1381f to
829373e
Compare
|
Done @danielRep |
danielRep
requested changes
Nov 5, 2025
Comment on lines
11
to
22
| ptr_uart->state = 0x3; | ||
| ptr_uart->intstatus = 0xf; | ||
| } | ||
|
|
||
| void uart_enable(volatile struct cmsdk_uart_hw* ptr_uart) | ||
| { | ||
| ptr_uart->ctrl = 0x1; | ||
| } | ||
|
|
||
| void uart_putc(volatile struct cmsdk_uart_hw* ptr_uart, int8_t c) | ||
| { | ||
| while (ptr_uart->state & 0x1) { } |
There was a problem hiding this comment.
Can we use macros instead of magic numbers?
josecm
force-pushed
the
feat/add_mps3_plat_support
branch
4 times, most recently
from
9f500d0 to
1e8fbb3
Compare
josecm
force-pushed
the
feat/add_mps3_plat_support
branch
2 times, most recently
from
6ff6589 to
9b67f2a
Compare
Signed-off-by: Jose Martins <[email protected]>
josecm
force-pushed
the
feat/add_mps3_plat_support
branch
from
9b67f2a to
fe1fc58
Compare
danielRep
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the cortex-r52 based MPS3 support. See https://documentation-service.arm.com/static/615dbd31ac265639eac54439?token=.
We only tested this support using the QEMU version of the platform (https://www.qemu.org/docs/master/system/arm/mps2.html)
This PR is dependent on #265.