Open
Conversation
$id may not always be an array. Currently triggering "argument must be of type array|object" warning. This validation fixes that issue.
|
The inspection completed: No new issues |
Collaborator
|
Which linter are you using out of interest? |
nelson6e65
requested changes
Apr 18, 2023
Collaborator
nelson6e65
left a comment
There was a problem hiding this comment.
Can you add this check in the isMultipleId method instead?
laravel-dynamodb/src/DynamoDbQueryBuilder.php
Lines 811 to 826 in 4e35d27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$id is not always an array. Currently triggering "argument must be of type array|object" warning when using strings and integers. The validation fixes that issue.