Open
Conversation
Mimic the classic query builder's pagination functions to wrap the result in a CursorPaginator. Instead of the built-in functionality to calculate the cursor based on the last returned item, we simply lean on the `lastEvaluatedKey` result from dynamo.
|
A new inspection was created. |
Author
|
Ah, the testbench requires laravel, so I didn't think about it too much, but since you did put illuminate/... packages into the require section, should I add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
paginatefunction similar to the existing functions on Laravel's query builder to return a slightly modifiedCursorPaginator, largely steamlining the process of paging result sets across multiple requests.We manage the
Cursorthrough Dynamo'slastEvaluatedKeyand use the same resolution strategy as the other paginators, so paging is seamless if you use the built-in stuff like resources and the pagination controls rendered by the paginator!