Fixes backward compatibility bug by providing alias for props & authStub#8
Open
udit7590 wants to merge 2 commits intobarberj:masterfrom
Open
Fixes backward compatibility bug by providing alias for props & authStub#8udit7590 wants to merge 2 commits intobarberj:masterfrom
udit7590 wants to merge 2 commits intobarberj:masterfrom
Conversation
Author
|
Hey @barberj . I think it'll be a critical bug for legacy codes. You have made a new attr_accessor :properties instead of :props and provided alias for only :props=. Similarly for authStub/client. Also your official documentation at https://code.exacttarget.com/apis-sdks/fuel-sdks/subscribers/subscriber-create.html also does not give any hint about the changes made in your gem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.