Skip to content

Confirm mvn clean test works without Maven profile — no changes needed#6

Closed
Copilot wants to merge 1 commit intofeature/align-maven-profiles-with-spring-boot-profiles-for-all-ai-providersfrom
copilot/sub-pr-2-again
Closed

Confirm mvn clean test works without Maven profile — no changes needed#6
Copilot wants to merge 1 commit intofeature/align-maven-profiles-with-spring-boot-profiles-for-all-ai-providersfrom
copilot/sub-pr-2-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 27, 2026

Review comment on #2 incorrectly claimed that ./mvnw clean test would fail to compile without a -P<provider> Maven profile flag, since Spring AI dependencies are profile-gated.

After investigation and user confirmation via direct testing, the claim was wrong:

  • Tests mock all Spring AI beans via @MockitoBean (ChatModel, ChatClient.Builder), so no provider-specific jars need to be wired at runtime
  • BattleContenderApplicationTest uses @ActiveProfiles("openai") to load the correct Spring config block, while mocks satisfy the bean requirements — the Maven openai profile is not required
  • No documentation or default-profile changes are needed — the README's ./mvnw clean test instruction is correct as-is

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update Maven profiles alignment with Spring profiles Confirm mvn clean test works without Maven profile — no changes needed Feb 27, 2026
@icougil icougil closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants