Skip to content

Add a default profile #7

Merged
anyulled merged 1 commit intomainfrom
feature/add-a-profile-by-default-otherwise-maven-does-not-download-the-ai-dependencies
Feb 28, 2026
Merged

Add a default profile #7
anyulled merged 1 commit intomainfrom
feature/add-a-profile-by-default-otherwise-maven-does-not-download-the-ai-dependencies

Conversation

@icougil
Copy link
Member

@icougil icougil commented Feb 28, 2026

…otherwise maven could fail because it won't download any AI dependency

@icougil
Copy link
Member Author

icougil commented Feb 28, 2026

@copilot can you create a similar pull request for the solution branch ?

Copy link
Contributor

Copilot AI commented Feb 28, 2026

@icougil I've opened a new pull request, #8, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a default Maven profile so the project always includes at least one Spring AI provider dependency when no -P... profile is specified, avoiding Maven build failures due to missing AI starter classes.

Changes:

  • Activates the openai Maven profile by default via <activeByDefault>true</activeByDefault>.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anyulled anyulled merged commit 01a068f into main Feb 28, 2026
6 checks passed
@icougil
Copy link
Member Author

icougil commented Feb 28, 2026

@copilot can you create a new PR with those changes also to be applied into the "solution" branch?

@icougil icougil deleted the feature/add-a-profile-by-default-otherwise-maven-does-not-download-the-ai-dependencies branch February 28, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants