Skip to content

$group arg support on TimelineCollectors methods #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barryvdh merged 2 commits into from
May 8, 2025
+9 −6
Merged

$group arg support on TimelineCollectors methods #1789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db9483e
`$group` arg support on TimelineCollectors methods
erikn69 May 2, 2025
ae8b20b
Add missing part
erikn69 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/LaravelDebugbar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,13 +675,14 @@ public function handleError($level, $message, $file = '', $line = 0, $context =
* @param string $name Internal name, used to stop the measure
* @param string $label Public name
* @param string|null $collector
* @param string|null $group
*/
public function startMeasure($name, $label = null, $collector = null)
public function startMeasure($name, $label = null, $collector = null, $group = null)
{
if ($this->hasCollector('time')) {
/** @var \DebugBar\DataCollector\TimeDataCollector */
$time = $this->getCollector('time');
$time->startMeasure($name, $label, $collector);
$time->startMeasure($name, $label, $collector, $group);
}
}

Expand Down Expand Up @@ -1094,13 +1095,14 @@ public function disable()
* @param float $end
* @param array|null $params
* @param string|null $collector
* @param string|null $group
*/
public function addMeasure($label, $start, $end, $params = [], $collector = null)
public function addMeasure($label, $start, $end, $params = [], $collector = null, $group = null)
{
if ($this->hasCollector('time')) {
/** @var \DebugBar\DataCollector\TimeDataCollector */
$time = $this->getCollector('time');
$time->addMeasure($label, $start, $end, $params, $collector);
$time->addMeasure($label, $start, $end, $params, $collector, $group);
}
}

Expand All @@ -1110,14 +1112,15 @@ public function addMeasure($label, $start, $end, $params = [], $collector = null
* @param string $label
* @param \Closure $closure
* @param string|null $collector
* @param string|null $group
* @return mixed
*/
public function measure($label, \Closure $closure, $collector = null)
public function measure($label, \Closure $closure, $collector = null, $group = null)
{
if ($this->hasCollector('time')) {
/** @var \DebugBar\DataCollector\TimeDataCollector */
$time = $this->getCollector('time');
$result = $time->measure($label, $closure, $collector);
$result = $time->measure($label, $closure, $collector, $group);
} else {
$result = $closure();
}
Expand Down
Loading