Skip to content

feat: use numeric type on fields with decimal casts #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barryvdh merged 3 commits into from
Oct 28, 2024
Merged

feat: use numeric type on fields with decimal casts #1583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecbe09e
feat: use `numeric` type on fields with `decimal` casts
ekisu Aug 18, 2024
3b383ed
docs: update CHANGELOG.md
ekisu Aug 18, 2024
b8018a2
Merge branch 'master' into numeric-string-on-decimal-casts
barryvdh Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ All notable changes to this project will be documented in this file.
### Changed
- Add support for multiple pivot types when using the same accessor.
- Smarter reset, keep tags that IDE helper doesn't use
- Use `numeric` type on fields with `decimal` casts


2024-10-18, 3.2.0
--------------
Expand Down
2 changes: 2 additions & 0 deletions src/Console/ModelsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,8 @@ public function castPropertiesType($model)
$realType = 'bool';
break;
case 'decimal':
$realType = 'numeric';
break;
case 'string':
case 'hashed':
$realType = 'string';
Expand Down
2 changes: 1 addition & 1 deletion tests/Console/ModelsCommand/SimpleCasts/__snapshots__/Test__test__1.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* @property float $cast_to_real
* @property float $cast_to_float
* @property float $cast_to_double
* @property string $cast_to_decimal
* @property numeric $cast_to_decimal
* @property string $cast_to_string
* @property bool $cast_to_bool
* @property bool $cast_to_boolean
Expand Down