fix: add @template TModel of static for Eloquent #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This works for me with something like |
Contributor
|
Working for me |
mfn
requested changes
Dec 23, 2024
Collaborator
mfn
left a comment
mfn
left a comment
There was a problem hiding this comment.
Can we have a test, please?
Contributor
Author
Hi @mfn Regarding writing test cases, do you have any ideas or suggestions? I'm not quite sure how to write test cases for this. |
mfn
approved these changes
Dec 26, 2024
Collaborator
mfn
left a comment
mfn
left a comment
There was a problem hiding this comment.
My bad, didn't realize we've no tests for this generator sadly.
LGTM 👍🏼
Owner
|
I think we need the other templates as well, right? #1634 |
Contributor
Owner
|
Yeah there where a few more, TValue or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: #1572
adding this docbloc for TModel of Eloquent class in ide-helper fix the return type.
Type of change