Skip calling fake() when required parameters exist (Socialite compatibility) #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error) The ide-helper attempted to invoke Facade::fake() unconditionally, which breaks when a facade (such as Laravel Socialite) requires a mandatory parameter in its fake() method signature. This resulted in an ArgumentCountError during `php artisan ide-helper:generate`. This patch adds a ReflectionMethod check and skips calling fake() when required parameters are present, ensuring compatibility with Socialite and preserving expected behavior for facades that support parameterless faking.
Owner
|
I think the error was resolved in #1745 but I guess this is the cleaner way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents
ide-helperfrom callingFacade::fake()on facades whosefake()method requires parameters.Laravel Socialite expects a required
$driverargument, causing anArgumentCountErrorduringphp artisan ide-helper:generate.By checking the number of required parameters via reflection and skipping such facades, the generator behaves correctly without affecting other facades that support parameterless faking.