Update index.rst: fix context processor path #260
Open
jeromecc wants to merge 8 commits intobarseghyanartur:old_masterfrom
Open
Update index.rst: fix context processor path #260jeromecc wants to merge 8 commits intobarseghyanartur:old_masterfrom
jeromecc wants to merge 8 commits intobarseghyanartur:old_masterfrom
Conversation
django.core.context_processors: Built-in template context processors have been moved to django.template.context_processors. Source: https://docs.djangoproject.com/en/dev/releases/1.8/#django-core-context-processors
barseghyanartur
requested changes
Jun 18, 2022
Owner
barseghyanartur
left a comment
barseghyanartur
left a comment
There was a problem hiding this comment.
Please, see my remarks.
| @@ -1,4 +1,5 @@ | |||
| {% load i18n fobi_tags %} | |||
| {% load i18n %} | |||
Owner
There was a problem hiding this comment.
Why are they loaded one per line? Templates are slow. Loading all the modules in one line makes them go a little bit faster.
| @@ -1,5 +1,7 @@ | |||
| {% extends fobi_theme.master_base_template %} | |||
|
|
|||
| {% load i18n %} | |||
Owner
There was a problem hiding this comment.
If we don't use i18n, we shouldn't load it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
django.core.context_processors:
Built-in template context processors have been moved to django.template.context_processors.
Source: https://docs.djangoproject.com/en/dev/releases/1.8/#django-core-context-processors