Update to .NET 10 and stable System.CommandLine #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project by updating to .NET 10 and migrating from the beta version of System.CommandLine to the stable 2.0.0 release. The migration includes API changes required for compatibility with the stable library release.
- Updated target framework from .NET 9.0 to .NET 10.0
- Migrated System.CommandLine from beta (2.0.0-beta4.22272.1) to stable (2.0.0) with corresponding API changes
- Updated dependent packages (Microsoft.CodeAnalysis 4.12.0 → 4.14.0, SonarAnalyzer.CSharp to 10.15.0.120848)
- Fixed output file extension handling in NormalizeCommand to preserve the original file extension
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SonarRulesetTool.csproj | Updated target framework to net10.0 and upgraded all package references to newer versions |
| src/Program.cs | Refactored to use new System.CommandLine API with explicit Parse/InvokeAsync pattern and renamed Register to Create |
| src/Commands/NormalizeCommand.cs | Migrated to stable System.CommandLine API using property initializers, SetAction instead of SetHandler, and fixed output file extension logic |
| src/Commands/ConvertCommand.cs | Migrated to stable System.CommandLine API using property initializers and SetAction instead of SetHandler |
| src/CommandArgumentParser.cs | Updated error reporting to use AddError method instead of ErrorMessage property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bart-vmware
force-pushed
the
update-net10
branch
from
ff09675 to
655145d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.