Skip to content

fixed Memory leak when opening PDF as a byte array #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed Memory leak when opening PDF as a byte array #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/main/jni/src/mainJNILib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,20 @@ class DocumentFile {
FPDF_DOCUMENT pdfDocument = NULL;
size_t fileSize;

public:
jbyte *cDataCopy = NULL;

DocumentFile() { initLibraryIfNeed(); }
~DocumentFile();
};
DocumentFile::~DocumentFile(){
if(pdfDocument != NULL){
FPDF_CloseDocument(pdfDocument);
}

if(cDataCopy != NULL){
free(cDataCopy);
cDataCopy = NULL;
}
destroyLibraryIfNeed();
}

Expand Down Expand Up @@ -238,13 +244,11 @@ JNI_FUNC(jlong, PdfiumCore, nativeOpenMemDocument)(JNI_ARGS, jbyteArray data, js
cpassword = env->GetStringUTFChars(password, NULL);
}

jbyte *cData = env->GetByteArrayElements(data, NULL);
int size = (int) env->GetArrayLength(data);
jbyte *cDataCopy = new jbyte[size];
memcpy(cDataCopy, cData, size);
env->GetByteArrayRegion(data, 0, size, cDataCopy);
FPDF_DOCUMENT document = FPDF_LoadMemDocument( reinterpret_cast<const void*>(cDataCopy),
size, cpassword);
env->ReleaseByteArrayElements(data, cData, JNI_ABORT);

if(cpassword != NULL) {
env->ReleaseStringUTFChars(password, cpassword);
Expand All @@ -269,7 +273,7 @@ JNI_FUNC(jlong, PdfiumCore, nativeOpenMemDocument)(JNI_ARGS, jbyteArray data, js
}

docFile->pdfDocument = document;

docFile->cDataCopy = cDataCopy;
return reinterpret_cast<jlong>(docFile);
}

Expand Down