Replace PluginTypeRepository and PluginRepository with KeyedCollection
#3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartfeenstra
added
enhancement
bartfeenstra
force-pushed
the
remove-plugin-repos
branch
4 times, most recently
from
19675a1 to
2be909d
Compare
bartfeenstra
commented
Feb 2, 2026
|
|
||
| _T = TypeVar("_T") | ||
| _KeyT = TypeVar("_KeyT") | ||
| _KeyCoT = TypeVar("_KeyCoT") |
Owner
Author
There was a problem hiding this comment.
Do we need the covariant types after all?
bartfeenstra
force-pushed
the
remove-plugin-repos
branch
from
2be909d to
b9d6a7f
Compare
bartfeenstra
force-pushed
the
remove-plugin-repos
branch
from
2e2e3b6 to
7e32026
Compare
bartfeenstra
commented
Feb 2, 2026
| """ | ||
| The plugin manager. | ||
| """ | ||
| from betty.service.plugin import PluginManager |
Owner
Author
There was a problem hiding this comment.
Can we make this a service?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3715
To do
PluginManagerlazily. That will also prevent the current circular imports.