optimize VNC screen capture and improve keyboard handling#9
Merged
vlad-terin merged 2 commits intobaryhuang:mainfrom Apr 1, 2025
vlad-terin:screenshotimprovement
Merged
optimize VNC screen capture and improve keyboard handling#9vlad-terin merged 2 commits intobaryhuang:mainfrom vlad-terin:screenshotimprovement
vlad-terin merged 2 commits intobaryhuang:mainfrom
vlad-terin:screenshotimprovement
Conversation
added 2 commits
March 31, 2025 12:59
…apping and add proper key mappings
baryhuang
approved these changes
Apr 1, 2025
Owner
baryhuang
left a comment
There was a problem hiding this comment.
I tested locally. It's working great! Thank you for the great improvement.
Feel free to merge any time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made several optimizations to improve the screen capture performance:
Incremental Updates:
Optimized Socket Reading:
_recv_exactmethod for efficient socket readingImage Processing Optimizations:
Error Handling Improvements:
You should notice: