Improve code for initializing array from a function#649
Open
samsamson33 wants to merge 1 commit intobasarat:masterfrom
Open
Improve code for initializing array from a function#649samsamson33 wants to merge 1 commit intobasarat:masterfrom
samsamson33 wants to merge 1 commit intobasarat:masterfrom
Conversation
`Array.from()` is, in my opinion at least, clearer in meaning than the spread operator with `Array.prototype.map()`. Also, as it does not create an intermediate array, it appears to be [around twice as fast](https://jsben.ch/phmxK) (on firefox).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array.from()is, in my opinion at least, clearer in meaning than the spread operator withArray.prototype.map(). Also, as it does not create an intermediate array, it appears to be around twice as fast (on firefox).