feat(KEYS-5638): task signature checking #565
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
imundra
commented
Jan 13, 2026
Comment on lines
+109
to
+119
| echo "📦 Creating deterministic tarball..." | ||
| if ! tar --sort=name \ | ||
| --mtime='1970-01-01 00:00:00' \ | ||
| --owner=0 --group=0 \ | ||
| --numeric-owner \ | ||
| -C "$network" \ | ||
| -cf "$temp_tar" \ | ||
| "$task_name/" 2>/dev/null; then | ||
| echo -e "${RED}❌ Failed to create tarball${NC}" | ||
| return 1 | ||
| fi |
Author
There was a problem hiding this comment.
this is going to get replaced with a call to a command line utility that @awilliams1-cb has in progress
imundra
commented
Jan 14, 2026
Comment on lines
+7
to
+8
| "sepolia" | ||
| "sepolia-alpha" |
Author
There was a problem hiding this comment.
we may want to remove these from the testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in checking for task signatures from the task author, and 2 facilitators. This is meant to serve as a safeguard against different signers signing different versions of the task. We don't perform actual cryptographic verification here but just check that the checksum that was signed is consistent across all of the signatures and the current state of the repo.