Fix broken link to existing apps migration guide#390
Closed
Elishaokon13 wants to merge 6 commits intobase:masterfrom
Closed
Fix broken link to existing apps migration guide#390Elishaokon13 wants to merge 6 commits intobase:masterfrom
Elishaokon13 wants to merge 6 commits intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Collaborator
|
Thanks, just saw this PR. We have a fix being merged now. Appreciate you taking the time to update this, will close since its a duplication |
Contributor
Author
|
Thank you, Eric! |
madisoncarter1234
pushed a commit
to madisoncarter1234/docs
that referenced
this pull request
Oct 27, 2025
<!-- start pr-codex -->
## PR-Codex overview
This PR updates the documentation regarding the specifications for valid
frame URLs, particularly clarifying the role of the manifest file and
its optional nature.
### Detailed summary
- Clarified that a valid frame URL includes an embed tag in its HTML
`<head>` and may optionally include a manifest file.
- Changed wording to specify that frames should provide a JSON manifest
file at the URI `/.well-known/farcaster.json`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Fixed broken link in the Mini Apps overview page. The link
/mini-apps/quickstart/existing-apps/installwas pointing to a non-existent file, causing a 404 error for users trying to learn about integrating existing web applications into Mini Apps.Changed the link from:
/mini-apps/quickstart/existing-apps/install(broken)To:
/mini-apps/quickstart/migrate-existing-apps(working)This ensures users can properly access the migration guide for converting existing web applications into Mini Apps.
Notes to reviewers
/mini-apps/quickstart/migrate-existing-apps.mdxexists and contains the relevant contentHow has it been tested?
/mini-apps/quickstart/migrate-existing-apps.mdxexists/mini-apps/quickstart/existing-apps/installwas indeed non-existentFixes: #386