Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
ericbrown99
previously approved these changes
Sep 26, 2025
cb-heimdall
dismissed
ericbrown99’s stale review
Approved review 3273975747 from ericbrown99 is now dismissed due to new commit. Re-request for approval.
- Consolidated and streamlined agent documentation content - Removed redundant files (best-practices.mdx, why-agents.mdx) and integrated content into other files - Enhanced building-quality-agents.mdx with improved guidance and best practices - Updated getting-featured.mdx with clearer instructions and better structure - Improved chat-agents.mdx with better content organization - Fixed sidebar navigation in docs.json to remove references to deleted files - Set clearer expectations for agent developers by framing process as getting feedback This consolidates all changes from PR #398 into a single comprehensive commit.
claudiahaddad
force-pushed
the
feature/agent-docs-verified-complete
branch
from
c9aa81f to
c962f0a
Compare
madisoncarter1234
pushed a commit
to madisoncarter1234/docs
that referenced
this pull request
Oct 27, 2025
- fix broken link on "see full example" on the frames spec page
- update `primaryButtonClick` to `primaryButtonClicked`
- remove broken wallet image
- fix minor format
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving the documentation for the `Frames` and
`Sign In with Farcaster (SIWF)` features, correcting grammatical errors
and enhancing clarity throughout various markdown files.
### Detailed summary
- Corrected "a way" to "a way" in `docs/developers/siwf/index.md`.
- Updated bullet points to start with capital letters in
`docs/developers/siwf/index.md`.
- Fixed "an click-through" to "a click-through" in
`docs/developers/frames/v2/getting-started.md`.
- Changed "servers" to "serves" in multiple instances in
`docs/developers/frames/v2/notifications_webhooks.md` and
`docs/developers/frames/v2/spec.md`.
- Updated event name from "primaryButtonClick" to "primaryButtonClicked"
in `docs/developers/frames/v2/spec.md`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/base-app/agents/best-practices.mdx - Content consolidated into other files
docs/base-app/agents/why-agents.mdx - Content consolidated into other files
docs/base-app/agents/building-quality-agents.mdx - Enhanced with improved content and guidance
docs/base-app/agents/getting-featured.mdx - Updated with better documentation structure
docs/docs.json - Fixed sidebar navigation to remove references to deleted files