Skip to content

feat(fbal): Add FAL spec v1, rename crate to access-lists #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danyalprout merged 7 commits into from
Jan 9, 2026
Merged

feat(fbal): Add FAL spec v1, rename crate to access-lists #323

danyalprout merged 7 commits into from
Jan 9, 2026

Conversation

@haardikk21
Copy link
Collaborator

@haardikk21 haardikk21 commented Jan 9, 2026 •
edited
Loading

  • Adds the FAL spec (v1) in the repo in SPEC.md
  • Renames the crate to access-lists to set the stage for future BAL work as well

Note

This PR is stacked on top of #322. Should merge #322 first before this.

@haardikk21 haardikk21 changed the title feat(fbal): Add FAL spec, rename crate to access-lists feat(fbal): Add FAL spec v1, rename crate to access-lists Jan 9, 2026
danyalprout
danyalprout previously approved these changes Jan 9, 2026
View reviewed changes
meyer9
meyer9 previously approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@meyer9 meyer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

refcell
refcell previously approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this nomenclature a lot better

Base automatically changed from fal-builder-db to main January 9, 2026 15:55
@haardikk21 haardikk21 dismissed stale reviews from refcell, meyer9, and danyalprout January 9, 2026 15:55

The base branch was changed.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 9, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 9, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

2 similar comments
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 9, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 9, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

meyer9
meyer9 previously approved these changes Jan 9, 2026
View reviewed changes
@haardikk21 haardikk21 requested a review from meyer9 January 9, 2026 15:59
@danyalprout danyalprout merged commit 36d2004 into main Jan 9, 2026
19 checks passed
@danyalprout danyalprout deleted the fal-spec branch January 9, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meyer9 meyer9 meyer9 approved these changes

@danyalprout danyalprout danyalprout left review comments

@refcell refcell refcell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@haardikk21 @cb-heimdall @danyalprout @meyer9 @refcell