fix(client): accumulate RPC extension hooks instead of replacing #446
+222
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BaseBuilderwrapper that accumulatesextend_rpc_modulesandon_node_startedhooks in vectors instead of replacing themTxPoolExtension,MeteringExtension,FlashblocksExtension) to use newadd_rpc_module()andadd_node_started_hook()methodsProblem
Reth's
extend_rpc_modulesandon_node_starteduse a replacement model—each call overwrites the previous hook. This caused only the last extension's hooks to execute, making endpoints likebase_meterBundleandbase_transactionStatusunavailable even when their respective extensions were enabled.Solution
The new
BaseBuilderwrapper collects all hooks during extension setup, then applies them all in a single reth call when launching. This maintains the existing extension API while fixing the accumulation issue.Closes #438
Test plan
cargo test --package base-client-node --features test-utilspassesbase_transactionStatus,base_meterBundle, flashblocks) are accessible when multiple extensions are enabled