fix(client): accumulate RPC extension hooks instead of replacing #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reth's `extend_rpc_modules` and `on_node_started` use a replacement model where each call overwrites the previous hook. This caused only the last extension's hooks to execute, making endpoints like `base_meterBundle` and `base_transactionStatus` unavailable. Introduce `BaseBuilder` wrapper that accumulates hooks in vectors, then applies them all in a single reth call when launching. This maintains the existing extension API while fixing the accumulation issue. Closes #438
niran
force-pushed
the
fix/rpc-extension-hook-accumulation-v0.3.0
branch
from
4924a7b to
2f3e12c
Compare
wlawt
approved these changes
Jan 14, 2026
danyalprout
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #446 to the v0.3.0 release branch.
Note: This cherry-pick required conflict resolution due to architectural differences between branches:
The core fix (hook accumulation via
BaseBuilder) is identical. The differences are in how extensions access the underlying builder for ExEx installation.Changes from main branch PR:
BaseBuilder.builderfield public so extensions can callinstall_exex()directly on the innerOpBuilderbuilder.builder.install_exex(...)patternProblem
Reth's
extend_rpc_modulesandon_node_starteduse a replacement model—each call overwrites the previous hook. This caused only the last extension's hooks to execute, making endpoints likebase_meterBundleandbase_transactionStatusunavailable.Solution
The new
BaseBuilderwrapper collects RPC and node-started hooks during extension setup, then applies them all in a single reth call when launching. The inner builder is exposed publicly for operations that don't need accumulation (like ExEx installation).Closes #438