fix: correct .env defaults and document HOST_DATA_DIR usage #884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with the default
.envfile and improves documentation to prevent users from accidentally mixing client data directories.Problem
The original
.envfile used shell variable interpolation syntax (${CLIENT:-geth}) which is not supported by Docker Compose's env_file parsing. Docker Compose reads.envfiles as simpleKEY=VALUEpairs without shell expansion, meaning:HOST_DATA_DIRwould resolve to the literal string./${CLIENT}-datainstead of./geth-dataAdditionally, when users switch clients (e.g., from
gethtoreth), they need to also updateHOST_DATA_DIRto avoid mixing data from different clients in the same directory.Changes
.envCLIENT=geth,HOST_DATA_DIR=./geth-data)README.mdHOST_DATA_DIRshould be set when changingCLIENTTesting
.envnow ends with a proper newline