-
Notifications
You must be signed in to change notification settings - Fork 47
perf: deduplicate bundles with the same contents #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| let bundle_cache = Cache::builder() | ||
| .time_to_live(Duration::from_secs(20)) | ||
| .build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this can just be a simple LruCache with 1k size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| // A TTL cache to deduplicate bundles with the same Bundle ID | ||
| let bundle_cache = Cache::builder() | ||
| .time_to_live(Duration::from_secs(20)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be more strict by having this be 10s which is 5 blocks (or 50 flashblocks) which is quite a long time
|
going to merge this into #123 as the experiment turned out fine |
* chore: use uuid v5 for determinism * feat: add ttl * diffs * fix: in-flight archive task * Revert "fix: in-flight archive task" This reverts commit a759f2b. * tmp: clear backlog by nooping * chore: log out meterbundleres
depends on #123
problem:
proposed solution:
notes:
This doesn't affect a transaction thats contained across multiple bundles, for example:
All have tx1 but the UUID will all be different (see how
bundle_hashis computed)