Skip to content

Base Token Creator from Smithii Tools submission#1299

Closed
Jorgerl02 wants to merge 4 commits intobase:masterfrom
Jorgerl02:master
Closed

Base Token Creator from Smithii Tools submission#1299
Jorgerl02 wants to merge 4 commits intobase:masterfrom
Jorgerl02:master

Conversation

@Jorgerl02
Copy link

What changed? Why?
I added Base Token Creator Information

Notes to reviewers
Submission to Base Ecosystem

How has it been tested?

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 24, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@vercel
Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:21am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:21am

@vercel
Copy link

vercel bot commented Nov 24, 2024

@Jorgerl02 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@wbnns
Copy link
Contributor

wbnns commented Dec 6, 2024

@Jorgerl02

Hi there! Thanks for building on Base! Could you please change the tags to from defi to infra?

@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related community contribution labels Dec 6, 2024
@Jorgerl02
Copy link
Author

Jorgerl02 commented Dec 6, 2024 via email

@wbnns
Copy link
Contributor

wbnns commented Dec 19, 2024

@Jorgerl02

Apologies, we recently updated the way we categorize and subcategorize apps after your change; could you please update your PR, conforming to the new format by removing the tag, and defining the category (infra) and subcategory (developer tools)?

We'll do our best to review as soon as possible once you do! 🙏

@Jorgerl02
Copy link
Author

Jorgerl02 commented Dec 19, 2024 via email

@wbnns wbnns added ready for merge Ready for merge, an additional reviewer is needed and removed change(s) requested One or more changes have been requested labels Dec 28, 2024
@wbnns wbnns enabled auto-merge (squash) December 28, 2024 12:10
@wbnns
Copy link
Contributor

wbnns commented Jan 15, 2025

@Jorgerl02 This can't be merged unless all of your commits are signed:
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

You may need to do a full rebase

@wbnns
Copy link
Contributor

wbnns commented Jan 25, 2025

@Jorgerl02

Hi there! Apologies, it looks like we can't bring this in because your commits aren't signed. Can you please rebase and sign your commits?

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@wbnns wbnns added change(s) requested One or more changes have been requested and removed ready for merge Ready for merge, an additional reviewer is needed labels Jan 25, 2025
@wbnns
Copy link
Contributor

wbnns commented Feb 5, 2025

Adding in #1702

@wbnns wbnns closed this Feb 5, 2025
auto-merge was automatically disabled February 5, 2025 00:10

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base ecosystem review This is ecosystem related change(s) requested One or more changes have been requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants