Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

feat(ecosystem): Add Toucan to ecosystem.json#1311

Closed
aspiers wants to merge 1 commit intobase:masterfrom
aspiers:toucan
Closed

feat(ecosystem): Add Toucan to ecosystem.json#1311
aspiers wants to merge 1 commit intobase:masterfrom
aspiers:toucan

Conversation

@aspiers
Copy link
Copy Markdown

@aspiers aspiers commented Nov 28, 2024 •
edited
Loading

What changed? Why?
Adds Toucan to the ecosystem page.

Notes to reviewers
Toucan has been live on Base since April 2024 (e.g. see https://dexscreener.com/watchlist/H4Elw1i20UH11iuKedY6 and https://app.toucan.earth/contracts#base).

How has it been tested?
Ran yarn workspace @app/web dev on localhost.

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 3:29pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 3:29pm

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 28, 2024

Someone is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Nov 28, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@wbnns
Copy link
Copy Markdown
Contributor

wbnns commented Dec 7, 2024

@aspiers

Hi there! Thanks for building on Base! Please change the tags from other to defi.

@wbnns wbnns self-assigned this Dec 7, 2024
@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related community contribution labels Dec 7, 2024
@aspiers aspiers force-pushed the toucan branch 2 times, most recently from 72a8540 to c240122 Compare December 7, 2024 10:37
@aspiers
Copy link
Copy Markdown
Author

aspiers commented Dec 7, 2024

@wbnns Done!

@wbnns wbnns removed their assignment Dec 18, 2024
@wbnns
Copy link
Copy Markdown
Contributor

wbnns commented Dec 19, 2024

@aspiers

Apologies, we recently updated the way we categorize and subcategorize apps; could you please update your PR, conforming to the new format by removing the tag, and defining the category (defi) and subcategory (dex)?

We'll do our best to review as soon as possible once you do! 🙏

@aspiers
Copy link
Copy Markdown
Author

aspiers commented Dec 22, 2024

@wbnns Updated. We're not a DEX but I couldn't find a way for us to neatly fit into the new taxonomy. The closest I found was consumer / real world since we tokenize carbon credits which are a form of RWA. We also provide on-chain baskets of carbon tokens which I guess could go under defi / portfolio, but it doesn't seem possible to select both.

@wbnns wbnns removed the change(s) requested One or more changes have been requested label Dec 28, 2024
@wbnns
Copy link
Copy Markdown
Contributor

wbnns commented Dec 28, 2024

@aspiers Thank you for this information, this is currently being reviewed.

wbnns
wbnns approved these changes Jan 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aspiers Thanks for building on Base 🔵

@wbnns wbnns added the ready for merge Ready for merge, an additional reviewer is needed label Jan 15, 2025
@aspiers aspiers force-pushed the toucan branch 2 times, most recently from 709073d to 948dbe1 Compare January 15, 2025 15:20
@aspiers
Copy link
Copy Markdown
Author

aspiers commented Jan 15, 2025

Rebased, fixed author email, and GPG-signed.

@wbnns wbnns removed the ready for merge Ready for merge, an additional reviewer is needed label Jan 25, 2025
@wbnns wbnns added the change(s) requested One or more changes have been requested label Jan 25, 2025
@wbnns
Copy link
Copy Markdown
Contributor

wbnns commented Jan 25, 2025

@aspiers Hello, apologies, we can't bring this in yet because your commit isn't signed:
https://github.com/base-org/web/pull/1311/commits

2025-01-25 at 15 57 55@2x

Here's the link to learn more:
https://docs.github.com/authentication/managing-commit-signature-verification/about-commit-signature-verification

@wbnns
Copy link
Copy Markdown
Contributor

wbnns commented Feb 5, 2025

Adding in #1702

@wbnns wbnns closed this Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wbnns wbnns wbnns approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

base ecosystem review This is ecosystem related change(s) requested One or more changes have been requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aspiers @cb-heimdall @wbnns