[ENSIP 19] Update set primary flow for SCWs#2588
Merged
arjun-dureja merged 6 commits intomasterfrom Sep 10, 2025
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arjun-dureja
force-pushed
the
arjun/ensip19-set-primary
branch
from
927a126 to
a4baebc
Compare
arjun-dureja
commented
Sep 10, 2025
| functionName: 'setNameForAddr', | ||
| }); | ||
| if (!paymasterServiceEnabled) { | ||
| await initiateTransaction({ |
Collaborator
Author
There was a problem hiding this comment.
@amiecorso Here's where you'll need to update this flow for EOAs
| const { initiateBatchCalls, batchCallsIsSuccess, batchCallsIsLoading } = | ||
| useWriteContractsWithLogs({ | ||
| chain: secondaryUsernameChain, | ||
| eventName: 'update_primary_name', |
Member
There was a problem hiding this comment.
Does this need to correspond to an onchain event? or is it just for client handling?
Collaborator
Author
There was a problem hiding this comment.
It's just for client side logging
stevieraykatz
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
setNameForAddron the ReverseRegistrar, and one for callingsetNameon the L2ReverseRegistrarNotes to reviewers
How has it been tested?
Screen.Recording.2025-09-09.at.7.52.02.PM.mov
Have you tested the following pages?
BaseWeb