-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(BA-2133): ENSIP-19 updates for registration flow for EOAs #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amiecorso
merged 10 commits into
master
from
amiecorso/ba-2133-registration-flow-for-eoas-in-web
Sep 10, 2025
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
614d8ea
Update registration flow for SCWs for ensip 19
arjun-dureja ee8e736
first stab at EOA updates for registration flow
amiecorso bf7ae22
Add contract addresses
arjun-dureja 3e8c3a6
works with EOA for regular registration and set-primary
amiecorso 7d3ebd7
some fixes after rebase
amiecorso 9b1d482
review comments
amiecorso 9ddefb3
Merge branch 'master' into amiecorso/ba-2133-registration-flow-for-eo…
amiecorso a1ad726
second round review comments
amiecorso 9824676
remove unused import
amiecorso 44109eb
fix linter error and warning for useRegisterNameCallback
amiecorso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This useState feels unnecessary since these values are only computed in
registerNameand don't depend on the react lifecycleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched this to use a ref, which from what I understand helps persist a value across renders though doesn't trigger a re-render if the value changes. Are you thinking we don't even need a ref because the signature will be used immediately upon its creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly, we don't need these values to persist across renders since the transaction using the signature is initiated in the same function (
registerName)Also, it's generally safer to re-request the signature every time register is clicked because there's currently no cache invalidation implemented. So a flow like this could happen:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠