Skip to content

feat: implement EIP-191 signing and encapsulate private key in ecdsaSigner #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jadonamite wants to merge 1 commit into from
Closed

feat: implement EIP-191 signing and encapsulate private key in ecdsaSigner #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions signer/ecdsa_signer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,52 @@ package signer

import (
"crypto/ecdsa"
"errors"
"math/big"

opcrypto "github.com/ethereum-optimism/optimism/op-service/crypto"
"github.com/ethereum/go-ethereum/accounts"
"github.com/ethereum/go-ethereum/accounts/abi/bind"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/crypto"
)

// ecdsaSigner represents an ECDSA signer.
type ecdsaSigner struct {
*ecdsa.PrivateKey
// privKey is encapsulated to prevent external mutation or accidental exposure.
privKey *ecdsa.PrivateKey
}

// NewECDSASigner validates the private key and returns a new signer instance.
func NewECDSASigner(pk *ecdsa.PrivateKey) (*ecdsaSigner, error) {
if pk == nil {
return nil, errors.New("signer: private key cannot be nil")
}
return &ecdsaSigner{privKey: pk}, nil
}

// Address returns the address associated with the ECDSA signer.
func (s *ecdsaSigner) Address() common.Address {
return crypto.PubkeyToAddress(s.PublicKey)
return crypto.PubkeyToAddress(s.privKey.PublicKey)
}

// SignerFn returns a signer function using the ECDSA private key and chain ID.
func (s *ecdsaSigner) SignerFn(chainID *big.Int) bind.SignerFn {
return opcrypto.PrivateKeySignerFn(s.PrivateKey, chainID)
return opcrypto.PrivateKeySignerFn(s.privKey, chainID)
}

// SignData signs the given data using the ECDSA private key.
// It applies the EIP-191 prefix ("\x19Ethereum Signed Message:\n") to prevent signing oracle attacks.
func (s *ecdsaSigner) SignData(data []byte) ([]byte, error) {
sig, err := crypto.Sign(crypto.Keccak256(data), s.PrivateKey)
// accounts.TextHash automatically handles the EIP-191 prefixing and hashing.
hash := accounts.TextHash(data)

sig, err := crypto.Sign(hash, s.privKey)
if err != nil {
return nil, err
}
// Adjust the recovery ID for Ethereum compatibility

// Adjust the recovery ID to match Ethereum 'v' value (27 or 28)
sig[crypto.RecoveryIDOffset] += 27
return sig, nil
}