Add warning override to DMSTask warning alarms#142
Open
mitchclarkebase2 wants to merge 1 commit intobase2Services:masterfrom
Open
Add warning override to DMSTask warning alarms#142mitchclarkebase2 wants to merge 1 commit intobase2Services:masterfrom
mitchclarkebase2 wants to merge 1 commit intobase2Services:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the default DMS task warning alarms so they reference the Warning alarm action instead of inheriting the Critical default, aligning deployed notification severity with intent.
Changes:
- Set
alarm.alarm_action = 'Warning'for theCDCLatencySourceWarnalarm. - Set
alarm.alarm_action = 'Warning'for theCDCLatencyTargetWarnalarm.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These alarms are getting deployed with the alarm action as critical, need to override that.