Gracefully handle ill-formed remote images in rich text#1859
Merged
flavorjones merged 1 commit intomainfrom Dec 4, 2025
Merged
Gracefully handle ill-formed remote images in rich text#1859flavorjones merged 1 commit intomainfrom
flavorjones merged 1 commit intomainfrom
Conversation
Member
Author
|
Hmm. Actually I think this is a bug in rails that's allowing remote images to be created with local URIs in the first place. Will work that angle also. |
Member
Author
|
Proposed upstream fix: rails/rails#56283 |
jorgemanrubia
approved these changes
Dec 3, 2025
Member
jorgemanrubia
left a comment
jorgemanrubia
left a comment
There was a problem hiding this comment.
TIL about skip_pipeline! 👏
A better fix has been proposed upstream at rails/rails#56283 but this should be fine in the meantime. ref: https://app.fizzy.do/5986089/cards/3188
flavorjones
force-pushed
the
flavorjones/fix-broken-remote-images
branch
from
7514598 to
89940d3
Compare
Member
Author
|
Looks good in staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A better fix has been proposed upstream at rails/rails#56283 but this should be fine in the meantime.
ref: https://app.fizzy.do/5986089/cards/3188