Skip to content

Change reaction admin permission check to be in-line with other controllers #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monorkin merged 1 commit into from
Dec 4, 2025
Merged

Change reaction admin permission check to be in-line with other controllers #1912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions app/controllers/cards/comments/reactions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ class Cards::Comments::ReactionsController < ApplicationController
include CardScoped

before_action :set_comment
before_action :set_reaction, only: %i[ destroy ]
before_action :ensure_permision_to_administer_reaction, only: %i[ destroy ]

def index
end
Expand All @@ -14,17 +16,19 @@ def create
end

def destroy
@reaction = @comment.reactions.find(params[:id])

if Current.user != @reaction.reacter
head :forbidden
else
@reaction.destroy
end
@reaction.destroy
end

private
def set_comment
@comment = @card.comments.find(params[:comment_id])
end

def set_reaction
@reaction = @comment.reactions.find(params[:id])
end

def ensure_permision_to_administer_reaction
head :forbidden if Current.user != @reaction.reacter
end
end