Skip to content

Sign up new users on sign in #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monorkin merged 1 commit into from
Dec 4, 2025
Merged

Sign up new users on sign in #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/controllers/sessions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,16 @@ def new
end

def create
if identity = Identity.find_by_email_address(email_address)
magic_link = identity.send_magic_link
serve_development_magic_link(magic_link)
identity = Identity.find_by_email_address(email_address)

magic_link = if identity
identity.send_magic_link
else
Signup.new(email_address: email_address).create_identity
end

serve_development_magic_link(magic_link)

redirect_to session_magic_link_path
end

Expand Down
9 changes: 6 additions & 3 deletions test/controllers/sessions_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,15 @@ class SessionsControllerTest < ActionDispatch::IntegrationTest

test "create for a new user" do
untenanted do
assert_no_difference -> { MagicLink.count } do
post session_path,
params: { email_address: "nonexistent-#{SecureRandom.hex(6)}@example.com" }
assert_difference -> { MagicLink.count }, +1 do
assert_difference -> { Identity.count }, +1 do
post session_path,
params: { email_address: "nonexistent-#{SecureRandom.hex(6)}@example.com" }
end
end

assert_redirected_to session_magic_link_path
assert MagicLink.last.for_sign_up?
end
end

Expand Down