Skip to content

Beautify board watchers list#1946

Merged
dhh merged 4 commits intomainfrom
beautify-board-watchers-list
Dec 5, 2025
Merged

Beautify board watchers list#1946
dhh merged 4 commits intomainfrom
beautify-board-watchers-list

Conversation

@dhh
Copy link
Member

@dhh dhh commented Dec 5, 2025

It was a little rough with all the concats. Prompted me to fix the long-standing issue where combining parameter content and block content for #tag would cause overwriting instead of concatenation too.

@dhh dhh merged commit d729cf5 into main Dec 5, 2025
11 checks passed
@dhh dhh deleted the beautify-board-watchers-list branch December 5, 2025 00:14
adjogima added a commit that referenced this pull request Dec 5, 2025
* main: (82 commits)
  We can remove ad-hoc handling now that we rely on page refreshes in the card perma
  Only broadcast when the preview changes, use the _later variant for the broadcast, add tests
  Update pinned cards when the title changes
  Rename to be more consistent
  Beautify board watchers list (#1946)
  Add missing data-attr on public board
  Fix hotkey text size on tiny viewports
  Use buil-in support for :self in Stimulus
  Save a bunch of invocations on morph events from children elements
  Fix: memoization was showing stale values when morphing
  GitHub actions: limit GITHUB_TOKEN permissions (#1933)
  Validate Identity email address
  Drop defunct user creation script
  Golden cards should be placed at the top
  Animate the column height with a stimulus controller so that it does not depend to the server to update when you D&D
  mise: respect .ruby-version
  Support custom validation messages
  Move css bit to the new blank slates CSS
  Prevent board names with only spaces and show validation message
  Keep the column color when D&D cards
  ...
adjogima added a commit that referenced this pull request Dec 5, 2025
…tylesheets+edits

* mobile-app/scoped-stylesheets: (82 commits)
  We can remove ad-hoc handling now that we rely on page refreshes in the card perma
  Only broadcast when the preview changes, use the _later variant for the broadcast, add tests
  Update pinned cards when the title changes
  Rename to be more consistent
  Beautify board watchers list (#1946)
  Add missing data-attr on public board
  Fix hotkey text size on tiny viewports
  Use buil-in support for :self in Stimulus
  Save a bunch of invocations on morph events from children elements
  Fix: memoization was showing stale values when morphing
  GitHub actions: limit GITHUB_TOKEN permissions (#1933)
  Validate Identity email address
  Drop defunct user creation script
  Golden cards should be placed at the top
  Animate the column height with a stimulus controller so that it does not depend to the server to update when you D&D
  mise: respect .ruby-version
  Support custom validation messages
  Move css bit to the new blank slates CSS
  Prevent board names with only spaces and show validation message
  Keep the column color when D&D cards
  ...
udiudi pushed a commit to udiudi/fizzy that referenced this pull request Dec 8, 2025
* Beautify board_watchers_list by escaping the concat jungle

* Correct it and clean it

* Latest Rails to get the content tag fix

* Test against original collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant