Add JSON activities API endpoint

[robzolkos]

Summary

This adds a JSON activities feed at GET /:account/activities.json so API clients can consume account activity directly, filter by creator and board, and receive normalized event metadata.

What changed

• Add ActivitiesController with a dedicated JSON index endpoint, separate from the HTML EventsController
• Scope the API feed to accessible events and supported event actions
• Add event scopes and preloading for creator, board, and eventable data
• Preload comment creator in Event.preloaded to avoid N+1 queries
• Serialize activities as a flat paginated array with top-level board, creator, and eventable payloads
• Normalize action-specific particulars for assignment, board changes, title changes, and triage events
• Document GET /:account_slug/activities in docs/api/sections/activities.md
• Add controller coverage for response shape, ordering, filtering, access scoping, particulars, and pagination

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[Copilot]

Pull request overview

This PR adds a JSON API endpoint for accessing account events, allowing API clients to consume activity feeds with filtering and pagination support. The implementation includes event scoping, particulars normalization, comprehensive tests, and API documentation.

Changes:

• Add JSON response format to EventsController#index with filtering by creator and board
• Implement scopes for event filtering and preloading required associations
• Create JSON serializers for events with top-level board/creator and normalized action-specific metadata
• Add comprehensive controller tests covering response shape, filtering, pagination, and access scoping
• Document the new API endpoint with query parameters, supported actions, and response examples

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
app/controllers/events_controller.rb	Added JSON response format, API_ACTIONS whitelist, and api_events filtering method
app/models/event.rb	Added reverse_chronologically, for_creators, for_boards scopes for API filtering
app/models/event/particulars.rb	Added api_particulars method to normalize action-specific metadata
app/views/events/index.json.jbuilder	JSON array renderer for paginated events
app/views/events/_event.json.jbuilder	Event JSON partial with board, creator, and eventable serialization
docs/API.md	Complete API documentation with query parameters, supported actions, and examples
test/controllers/events_controller_test.rb	Comprehensive tests for response format, filtering, pagination, and access control

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

app/models/event.rb:24

• The Event.preloaded scope doesn't explicitly include the creator for Comment eventables. When the event partial renders a Comment, it accesses comment.creator (in the comment.json.jbuilder partial), which will trigger an N+1 query issue. Consider updating the preload to include the comment's creator and card associations.

  scope :preloaded, -> {
    includes(:creator, :board, {
      eventable: [
        :goldness, :closure, :image_attachment,
        { rich_text_body: :embeds_attachments },
        { rich_text_description: :embeds_attachments },
        { card: [ :goldness, :closure, :image_attachment ] }
      ]
    })
  }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[flavorjones]

Just an aside -- I was not aware we have been doing this nested particulars thing, and now my OCD is kicking in. 😮‍💨

[robzolkos]

Yeah thats not elegant. I'll see how big of an issue it is and fix either in this or subsequent PR.

[robzolkos]

@flavorjones this would be pretty big push to fix (would need a migration to over all the events recorded so far). Not in scope for this PR.

[flavorjones]

This is good and we can probably ship it. But I left some comments, particularly around whether we should make a new controller for this. Would love your thoughts?

[flavorjones]

The respond_to makes it explicit that HTML and JSON paths use different data sources ... but that feels like kind of a smell, too (like the DayTimelinesScoped module) which is making me wonder if this should be a separate controller.

[robzolkos]

@flavorjones I think your instinct is right and I should have seen it - the behaviour and data were different and I was trying to squeeze them into the one controller. I have moved the JSON Api to its own Activities controller. It's sole purpose is to provide the json activity stream. The Events controller drives the HTML board activity view. Thoughts?