Merged
Conversation
Adds a mechanism to automatically scope cookie paths to match
`--path-prefix`.
When `--scope-cookie-paths` is `true` and a request matches a
`--path-prefix`, any cookies set by the response will automatically have
their paths scoped to the matched prefix.
For example, given a service that is deployed with:
... --path-prefix=/app,api
And a response that sets a cookie like:
Set-Cookie: session=1; Secure; Path=/; Domain=example.com
Then for a request to `/app/something`, the client will actually receive
a cookie header of:
Set-Cookie: session=1; Secure; Path=/app; Domain=example.com
This feature is intended to make it easier to allow multiple, distinct
applications to share the same domain by using different paths, without
them accidentally clobbering each others' cookies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mechanism to automatically scope cookie paths to match
--path-prefix.When
--scope-cookie-pathsistrueand a request matches a--path-prefix, any cookies set by the response will automatically have their paths scoped to the matched prefix.For example, given a service that is deployed with:
And a response that sets a cookie like:
Then for a request to
/app/something, the client will actually receive a cookie header of:This feature is intended to make it easier to allow multiple, distinct applications to share the same domain by using different paths, without them accidentally clobbering each others' cookies.